refactor(editor-app): 改进架构和类型安全 (#226)

* refactor(editor-app): 改进架构和类型安全

* refactor(editor-app): 开始拆分 Inspector.tsx - 创建基础架构

* refactor(editor-app): 完成 Inspector.tsx 拆分

* refactor(editor-app): 优化 Inspector 类型定义,消除所有 any 使用

* refactor(editor): 实现可扩展的属性渲染器系统

* Potential fix for code scanning alert no. 231: Unused variable, import, function or class

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* fix(ci): 防止 Codecov 服务故障阻塞 CI 流程

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This commit is contained in:
YHH
2025-11-18 22:28:13 +08:00
committed by GitHub
parent bce3a6e253
commit caed5428d5
48 changed files with 2221 additions and 44 deletions

View File

@@ -0,0 +1,36 @@
import type { IJsonModel, IJsonTabNode, IJsonBorderNode as FlexBorderNode } from 'flexlayout-react';
export interface IJsonRowNode {
type: 'row';
id?: string;
weight?: number;
children: IJsonLayoutNode[];
}
export interface IJsonTabsetNode {
type: 'tabset';
id?: string;
weight?: number;
selected?: number;
children: IJsonTabNode[];
}
export type IJsonLayoutNode = IJsonRowNode | IJsonTabsetNode | IJsonTabNode;
export type { FlexBorderNode as IJsonBorderNode };
export function isTabsetNode(node: IJsonLayoutNode): node is IJsonTabsetNode {
return node.type === 'tabset';
}
export function isRowNode(node: IJsonLayoutNode): node is IJsonRowNode {
return node.type === 'row';
}
export function isTabNode(node: IJsonLayoutNode): node is IJsonTabNode {
return node.type === 'tab';
}
export function hasChildren(node: IJsonLayoutNode): node is IJsonRowNode | IJsonTabsetNode {
return node.type === 'row' || node.type === 'tabset';
}

View File

@@ -1,5 +1,7 @@
import type { IJsonModel, IJsonTabNode } from 'flexlayout-react';
import type { FlexDockPanel } from './types';
import type { IJsonLayoutNode, IJsonBorderNode, IJsonTabsetNode } from './FlexLayoutTypes';
import { hasChildren, isTabNode, isTabsetNode } from './FlexLayoutTypes';
export class LayoutMerger {
static merge(savedLayout: IJsonModel, defaultLayout: IJsonModel, currentPanels: FlexDockPanel[]): IJsonModel {
@@ -31,21 +33,23 @@ export class LayoutMerger {
private static collectPanelIds(layout: IJsonModel): Set<string> {
const panelIds = new Set<string>();
const collect = (node: any) => {
if (node.type === 'tab' && node.id) {
const collect = (node: IJsonLayoutNode) => {
if (isTabNode(node) && node.id) {
panelIds.add(node.id);
}
if (node.children) {
node.children.forEach((child: any) => collect(child));
if (hasChildren(node)) {
node.children.forEach((child) => collect(child as IJsonLayoutNode));
}
};
collect(layout.layout);
if (layout.layout) {
collect(layout.layout as IJsonLayoutNode);
}
if (layout.borders) {
layout.borders.forEach((border: any) => {
layout.borders.forEach((border: IJsonBorderNode) => {
if (border.children) {
collect({ children: border.children });
border.children.forEach((child) => collect(child as IJsonLayoutNode));
}
});
}
@@ -55,61 +59,59 @@ export class LayoutMerger {
private static clearBorders(layout: IJsonModel): void {
if (layout.borders) {
layout.borders = layout.borders.map((border: any) => ({
layout.borders = layout.borders.map((border: IJsonBorderNode) => ({
...border,
children: []
}));
}
}
private static removePanels(node: any, removedPanelIds: string[]): boolean {
if (!node.children) return false;
private static removePanels(node: IJsonLayoutNode, removedPanelIds: string[]): boolean {
if (!hasChildren(node)) return false;
if (node.type === 'tabset' || node.type === 'row') {
const originalLength = node.children.length;
node.children = node.children.filter((child: any) => {
if (child.type === 'tab') {
return !removedPanelIds.includes(child.id);
}
return true;
});
if (node.type === 'tabset' && node.children.length < originalLength) {
if (node.selected >= node.children.length) {
node.selected = Math.max(0, node.children.length - 1);
}
const originalLength = node.children.length;
node.children = node.children.filter((child) => {
if (isTabNode(child)) {
return !removedPanelIds.includes(child.id || '');
}
return true;
}) as any;
node.children.forEach((child: any) => this.removePanels(child, removedPanelIds));
return node.children.length < originalLength;
if (isTabsetNode(node) && node.children.length < originalLength) {
if (node.selected !== undefined && node.selected >= node.children.length) {
node.selected = Math.max(0, node.children.length - 1);
}
}
return false;
node.children.forEach((child) => this.removePanels(child as IJsonLayoutNode, removedPanelIds));
return node.children.length < originalLength;
}
private static findNewPanels(node: any, newPanelIds: string[]): IJsonTabNode[] {
private static findNewPanels(node: IJsonLayoutNode, newPanelIds: string[]): IJsonTabNode[] {
const newPanelTabs: IJsonTabNode[] = [];
const find = (n: any) => {
if (n.type === 'tab' && n.id && newPanelIds.includes(n.id)) {
const find = (n: IJsonLayoutNode) => {
if (isTabNode(n) && n.id && newPanelIds.includes(n.id)) {
newPanelTabs.push(n);
}
if (n.children) {
n.children.forEach((child: any) => find(child));
if (hasChildren(n)) {
n.children.forEach((child) => find(child as IJsonLayoutNode));
}
};
find(node);
return newPanelTabs;
}
private static addNewPanelsToCenter(node: any, newPanelTabs: IJsonTabNode[]): boolean {
if (node.type === 'tabset') {
const hasNonSidePanel = node.children?.some((child: any) => {
private static addNewPanelsToCenter(node: IJsonLayoutNode, newPanelTabs: IJsonTabNode[]): boolean {
if (isTabsetNode(node)) {
const hasNonSidePanel = node.children?.some((child) => {
const id = child.id || '';
return !id.includes('hierarchy') &&
!id.includes('asset') &&
!id.includes('inspector') &&
!id.includes('console');
return (
!id.includes('hierarchy') &&
!id.includes('asset') &&
!id.includes('inspector') &&
!id.includes('console')
);
});
if (hasNonSidePanel && node.children) {
@@ -119,9 +121,9 @@ export class LayoutMerger {
}
}
if (node.children) {
if (hasChildren(node)) {
for (const child of node.children) {
if (this.addNewPanelsToCenter(child, newPanelTabs)) {
if (this.addNewPanelsToCenter(child as IJsonLayoutNode, newPanelTabs)) {
return true;
}
}