fix: 修复CodeQL检测到的代码问题

This commit is contained in:
yhh
2025-12-03 18:08:19 +08:00
parent f7535a2aac
commit 293ac2dca3
18 changed files with 60 additions and 67 deletions

View File

@@ -45,7 +45,7 @@ export const TilemapViewport: React.FC<TilemapViewportProps> = ({
panX,
panY,
showGrid,
showCollision,
showCollision: _showCollision,
selectedTiles,
brushSize,
currentLayer,
@@ -63,12 +63,12 @@ export const TilemapViewport: React.FC<TilemapViewportProps> = ({
const [isPanning, setIsPanning] = useState(false);
const [lastPanPos, setLastPanPos] = useState({ x: 0, y: 0 });
const [mousePos, setMousePos] = useState<{ tileX: number; tileY: number } | null>(null);
const [_mousePos, setMousePos] = useState<{ tileX: number; tileY: number } | null>(null);
const [spacePressed, setSpacePressed] = useState(false);
// Get canvas size
const canvasWidth = tilemap.width * tileWidth;
const canvasHeight = tilemap.height * tileHeight;
// Get canvas size (reserved for future virtual scrolling)
const _canvasWidth = tilemap.width * tileWidth;
const _canvasHeight = tilemap.height * tileHeight;
// Initialize viewport service
useEffect(() => {

View File

@@ -223,7 +223,7 @@ export const TilesetPreview: React.FC<TilesetPreviewProps> = ({
});
};
const handleCloseContextMenu = () => {
const _handleCloseContextMenu = () => {
setContextMenu(null);
};

View File

@@ -49,7 +49,7 @@ export const TileSetSelectorPanel: React.FC<TileSetSelectorPanelProps> = ({
} = useTilemapEditorStore();
const [showTilesetDropdown, setShowTilesetDropdown] = useState(false);
const [previewZoom, setPreviewZoom] = useState(1);
const [_previewZoom, _setPreviewZoom] = useState(1);
const [editingAnimationTileId, setEditingAnimationTileId] = useState<number | null>(null);
// Get animated tile IDs from tileset

View File

@@ -3,7 +3,7 @@
* Tilemap 详情面板 - 右侧分组属性面板
*/
import React, { useState, useCallback, useRef, useEffect } from 'react';
import React, { useState, useCallback, useRef } from 'react';
import {
ChevronDown,
ChevronRight,
@@ -412,7 +412,7 @@ export const TilemapDetailsPanel: React.FC<TilemapDetailsPanelProps> = ({
// Colors for grid (editor settings, not layer properties)
const [tileGridColor, setTileGridColor] = useState('#333333');
const [multiTileGridColor, setMultiTileGridColor] = useState('#ff0000');
const [layerGridColor, setLayerGridColor] = useState('#00ff00');
const [_layerGridColor, _setLayerGridColor] = useState('#00ff00');
const handleLayerSelect = useCallback((index: number) => {
setCurrentLayer(index);

View File

@@ -18,13 +18,12 @@ import {
FolderOpen,
File,
Image as ImageIcon,
ChevronDown,
AlertTriangle,
Box,
Map
} from 'lucide-react';
import { Core, Entity } from '@esengine/ecs-framework';
import { MessageHub, ProjectService, IFileSystemService, type IFileSystem, IDialogService, type IDialog } from '@esengine/editor-core';
import { Core } from '@esengine/ecs-framework';
import { MessageHub, ProjectService, IFileSystemService, type IFileSystem, type IDialog } from '@esengine/editor-core';
import { TilemapComponent, type ITilesetData, type ResizeAnchor } from '@esengine/tilemap';
import { useTilemapEditorStore, type TilemapToolType, type LayerState } from '../../stores/TilemapEditorStore';
import { TilemapCanvas } from '../TilemapCanvas';
@@ -567,7 +566,7 @@ const PanelDivider: React.FC<PanelDividerProps> = ({ onDrag, direction }) => {
export const TilemapEditorPanel: React.FC<TilemapEditorPanelProps> = ({ messageHub: propMessageHub }) => {
const [tilemap, setTilemap] = useState<TilemapComponent | null>(null);
const [entity, setEntity] = useState<Entity | null>(null);
const [_entity, setEntity] = useState<unknown>(null);
// Panel widths for resizable layout - smaller defaults to give viewport more space
const [leftPanelWidth, setLeftPanelWidth] = useState(180);
@@ -595,12 +594,12 @@ export const TilemapEditorPanel: React.FC<TilemapEditorPanelProps> = ({ messageH
entityId,
pendingFilePath,
currentFilePath,
currentTool,
currentTool: _currentTool,
zoom,
showGrid,
showCollision,
editingCollision,
tileWidth,
showCollision: _showCollision,
editingCollision: _editingCollision,
tileWidth: _tileWidth,
tileHeight,
tilesetImageUrl,
tilesetColumns,
@@ -608,11 +607,11 @@ export const TilemapEditorPanel: React.FC<TilemapEditorPanelProps> = ({ messageH
setEntityId,
setPendingFilePath,
setCurrentFilePath,
setCurrentTool,
setCurrentTool: _setCurrentTool,
setZoom,
setShowGrid,
setShowCollision,
setEditingCollision,
setEditingCollision: _setEditingCollision,
setPan,
setTileset,
setLayers,
@@ -989,8 +988,8 @@ export const TilemapEditorPanel: React.FC<TilemapEditorPanelProps> = ({ messageH
setPan(0, 0);
};
// 退出全屏模式
const handleExitFullscreen = useCallback(() => {
// 退出全屏模式 (reserved for future use)
const _handleExitFullscreen = useCallback(() => {
messageHub?.publish('editor:fullscreen', { fullscreen: false });
}, [messageHub]);

View File

@@ -3,7 +3,6 @@
* Tilemap Editor Module Entry
*/
import React from 'react';
import type { ServiceContainer, Entity } from '@esengine/ecs-framework';
import { Core } from '@esengine/ecs-framework';
import type {
@@ -24,7 +23,6 @@ import {
ComponentRegistry,
IDialogService,
IFileSystemService,
UIRegistry,
FileActionRegistry
} from '@esengine/editor-core';
import type { IDialog, IFileSystem } from '@esengine/editor-core';